Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix sonarcloud python:S117 #172

Merged
merged 1 commit into from
Oct 14, 2022
Merged

fix: fix sonarcloud python:S117 #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions dynamodump/dynamodump.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,17 +643,19 @@ def do_empty(dynamo, table_name, billing_mode):
)


def do_backup(dynamo, read_capacity, tableQueue=None, srcTable=None, filterOption=None):
def do_backup(
dynamo, read_capacity, table_queue=None, src_table=None, filter_option=None
):
"""
Connect to DynamoDB and perform the backup for srcTable or each table in tableQueue
Connect to DynamoDB and perform the backup for src_table or each table in table_queue
"""

if srcTable:
table_name = srcTable
if src_table:
table_name = src_table

if tableQueue:
if table_queue:
while True:
table_name = tableQueue.get()
table_name = table_queue.get()
if table_name is None:
break

Expand Down Expand Up @@ -700,8 +702,8 @@ def do_backup(dynamo, read_capacity, tableQueue=None, srcTable=None, filterOptio
optional_args = {}
if last_evaluated_key is not None:
optional_args["ExclusiveStartKey"] = last_evaluated_key
if filterOption is not None:
optional_args.update(filterOption)
if filter_option is not None:
optional_args.update(filter_option)
scanned_table = dynamo.scan(
TableName=table_name, **optional_args
)
Expand All @@ -711,7 +713,7 @@ def do_backup(dynamo, read_capacity, tableQueue=None, srcTable=None, filterOptio
+ table_name
+ ". BACKUP FOR IT IS USELESS."
)
tableQueue.task_done()
table_queue.task_done()

f = open(
args.dumpPath
Expand Down Expand Up @@ -755,7 +757,7 @@ def do_backup(dynamo, read_capacity, tableQueue=None, srcTable=None, filterOptio
+ str(datetime.datetime.now().replace(microsecond=0) - start_time)
)

tableQueue.task_done()
table_queue.task_done()


def prepare_provisioned_throughput_for_restore(provisioned_throughput):
Expand Down Expand Up @@ -1330,15 +1332,15 @@ def main():
do_backup(
conn,
args.read_capacity,
tableQueue=None,
filterOption=filter_option,
table_queue=None,
filter_option=filter_option,
)
else:
do_backup(
conn,
args.read_capacity,
matching_backup_tables,
filterOption=filter_option,
filter_option=filter_option,
)
except AttributeError:
# Didn't specify srcTable if we get here
Expand All @@ -1350,7 +1352,7 @@ def main():
t = threading.Thread(
target=do_backup,
args=(conn, args.readCapacity),
kwargs={"tableQueue": q, "filterOption": filter_option},
kwargs={"table_queue": q, "filter_option": filter_option},
)
t.start()
threads.append(t)
Expand Down