Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eth_senduseroperation): allow 0 for request ID & support gas limit markup #750

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

TheDivic
Copy link
Collaborator

📖 Context

Type of change

  • Non-breaking change (backwards compatible)

Why are we doing this?

  • We incorrectly checked the JSON-RPC request ID, and it would generate a new request ID in case the client sent 0, and we should always return whatever the client sent.
  • Gnosis estimate gas returns a low gas limit consistently.

What did we do?

  • Check if the request ID is defined and not "truthy".
  • Allow adding a markup (in wei) to the call gas limit returned from simulation to handle cases where the RPC doesn't return the correct estimate from eth_estimateGas (for example on Gnosis).

@TheDivic TheDivic added the 🐛 Bug Something isn't working label Nov 18, 2024
@TheDivic TheDivic self-assigned this Nov 18, 2024
@TheDivic TheDivic merged commit f36bbd6 into master Nov 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants