Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/mainnnet stale message bug #762

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Fix/mainnnet stale message bug #762

merged 2 commits into from
Jan 23, 2025

Conversation

TheDivic
Copy link
Collaborator

@TheDivic TheDivic commented Jan 23, 2025 •
edited
Loading

📖 Context

Type of change

  • Non-breaking change (backwards compatible)

Why are we doing this?

  • Ethereum Sepolia was not enabled on EPv0.7.0
  • There was a bug with a missing timestamp causing EPv0.7.0 user operation queue messages to be discarded as stale as soon as they enter the queue. This would cause the client operation to timeout and the user op would never be submitted on chain. This bug was present both on Mainnet and Sepolia.

Related issues:

What did we do?

  • Added the timestamp when adding the operation to the mempool
  • Enabled Sepolia
  • Deleted some dead code
  • Added a E2E test for Sepolia

@TheDivic TheDivic added the 🐛 Bug Something isn't working label Jan 23, 2025
@TheDivic TheDivic requested a review from fichiokaku January 23, 2025 15:06
@TheDivic TheDivic self-assigned this Jan 23, 2025
@TheDivic TheDivic merged commit 6697183 into master Jan 23, 2025
5 checks passed
@TheDivic TheDivic deleted the fix/mainnnet-stale-message-bug branch January 23, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fichiokaku fichiokaku fichiokaku approved these changes

Assignees

@TheDivic TheDivic

Labels
🐛 Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheDivic @fichiokaku