Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/add rabbitmq try catch handlers #763

Merged
merged 6 commits into from
Jan 24, 2025

Conversation

TheDivic
Copy link
Collaborator

📖 Context

Type of change

  • Non-breaking change (backwards compatible)

Why are we doing this?

  • RabbitMQ was crashing the production bundler with PRECONDITION_FAILED - unknown delivery tag 1

What did we do?

  • Wrapped all ack and other RabbitMQ methods in try / catch clauses to debug and prevent the bundler from crashing
  • Updated the RabbitMQ and amqplib versions
  • Share the same connection between all networks instead of connecting every time

How Has This Been Tested?

  • Sent a few user ops on a few different networks through my local bundler instance with the new version of rabbit

fichiokaku and others added 5 commits January 24, 2025 13:42
Update RabbitMQ to v3.13, update amqplib, share a single connection between all network consumers. Also add a default gas limit markup to Blast.
…y/bundler into fix/add-rabbitmq-try-catch-handlers
@TheDivic TheDivic added the 🐛 Bug Something isn't working label Jan 24, 2025
@TheDivic TheDivic requested review from TakGN and fichiokaku January 24, 2025 13:07
@TheDivic TheDivic self-assigned this Jan 24, 2025
fichiokaku
fichiokaku previously approved these changes Jan 24, 2025
@TheDivic TheDivic merged commit 6ce29ac into master Jan 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants