Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rabbitmq): 🐛 Disable heartbeat, add additional try/catch #764

Merged
merged 7 commits into from
Jan 25, 2025
Merged

fix(rabbitmq): 🐛 Disable heartbeat, add additional try/catch #764

merged 7 commits into from
Jan 25, 2025

Conversation

TheDivic
Copy link
Collaborator

  • Disable connection heartbeat because it's recommended in the CloudAMQP diagnostics panel.
  • Wrap additional ack calls in a try / catch clause

@TheDivic TheDivic added the 🐛 Bug Something isn't working label Jan 24, 2025
@TheDivic TheDivic requested review from TakGN and fichiokaku January 24, 2025 22:56
@TheDivic TheDivic self-assigned this Jan 24, 2025
fichiokaku
fichiokaku previously approved these changes Jan 24, 2025
View reviewed changes
@TheDivic TheDivic merged commit a5fb7cc into master Jan 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fichiokaku fichiokaku fichiokaku left review comments

@TakGN TakGN Awaiting requested review from TakGN

Assignees

@TheDivic TheDivic

Labels
🐛 Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheDivic @fichiokaku @TakGN