Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: add multisig cli #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tynes
Copy link
Member

@tynes tynes commented Feb 6, 2019

Work in progress pull request, still need to implement a few things

  • finish implementing these methods

  • getProposalMTX

  • approveProposal

  • rejectProposal

  • sendProposal

  • decide if multisig commands should be behind multisig flag, like admin commands

  • add websocket event listeners for multisig specific events

@nodech
Copy link
Member

nodech commented Feb 6, 2019

Because we call this bmultisig-client there's no need to have them behind multisig commands.

@tynes
Copy link
Member Author

tynes commented Feb 6, 2019

Similar to the admin commands that follow admin, I was wondering if the multisig commands should follow multisig ie:

./bmultisig-cli multisig proposals

or

./bmultisig-cli proposals

Its a matter of UX and compatibility with bwallet-cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants