Skip to content

Commit

Permalink
Don't open Windows console with the GUI
Browse files Browse the repository at this point in the history
In Windows, Unison has always opened the Windows console even for the
GUI application. Historically, it has been required because there was no
pty support in Windows and also because the existence of working stdout
and stderr was taken for granted. The console does not need to be opened
by default and be visible at all times. It will be opened by Windows for
the ssh process, as required (or better yet, the new pty support will be
used). As for other stdout and stderr output, normal use of Unison GUI
should not produce any such output and does not require the console.
  • Loading branch information
tleedjarv committed Aug 25, 2021
1 parent 149be09 commit b423d1d
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions src/Makefile.OCaml
Original file line number Diff line number Diff line change
Expand Up @@ -257,10 +257,12 @@ endif

# Patch to make a Windows GUI version come up with no
# console when click-started
# ifeq ($(OSARCH), win32)
ifeq ($(OSARCH), win32)
ifneq ($(UISTYLE), text)
# COBJS+=winmain.c
# CFLAGS+=-cclib /subsystem:windows
# endif
CFLAGS+=-ccopt "-link -Wl,--subsystem,windows"
endif
endif

# Gtk GUI
ifeq ($(UISTYLE), gtk)
Expand Down

0 comments on commit b423d1d

Please sign in to comment.