Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "hello-world" workflow for (other) directories. #260

Closed
wants to merge 6 commits into from

Conversation

KsaR99
Copy link
Contributor

@KsaR99 KsaR99 commented Dec 18, 2024

Currently It runs on any commit to any file.

@PEZ
Copy link
Collaborator

PEZ commented Dec 18, 2024

It should run for changes to compile.sh and run.sh. Maybe better with a blacklist of directories. So not run for files in loops, levenshtein, or fibonacci.

Add white list + remove unnecessary "compontents: 'native-image'"
@KsaR99
Copy link
Contributor Author

KsaR99 commented Dec 19, 2024

  • I added compile.sh & run.sh to white list.
  • Also removed components: 'native-image' due to issue in actions

issue

Please remove "components: 'native-image'" from your workflow file. It is automatically included since GraalVM for JDK 17: oracle/graal#5995

cc @PEZ, @bddicken

@PEZ
Copy link
Collaborator

PEZ commented Dec 19, 2024

To me it makes total sense to do these changes, @bddicken. I don't think we'll be running the other benchmarks in CI anyway. At least not on all commits.

@KsaR99 KsaR99 closed this by deleting the head repository Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants