Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Tongyong Pinyin, Wade-Giles and Gwoyeu Romatzyh #2

Open
bdon opened this issue Jul 7, 2020 · 3 comments
Open

support Tongyong Pinyin, Wade-Giles and Gwoyeu Romatzyh #2

bdon opened this issue Jul 7, 2020 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@bdon
Copy link
Owner

bdon commented Jul 7, 2020

No description provided.

@bdon bdon added the good first issue Good for newcomers label Jul 7, 2020
@bdon bdon self-assigned this Feb 24, 2021
@WainLai
Copy link

WainLai commented Dec 25, 2021

Hello,
I don't know much about coding, but I find the tool you created (https://bdon.org/hanzireader/) very useful. You mention Tongyong support. Does it mean Chinese text can be converted to Tongyong? If yes, how?

@bdon
Copy link
Owner Author

bdon commented Dec 28, 2021

Hi,

I haven't implemented Tongyong support yet; to do that you need to add a new transliterator alongside zhuyin and pinyin here: https://github.com/bdon/hanzi2reading/blob/master/js/hanzi2reading.js#L24

The main motivation for eventually adding Tongyong support is to correctly implement text conversion for place names in Taiwan.

@WainLai
Copy link

WainLai commented Dec 28, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants