Update to Python-Babel 3.0.0 #1550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 3.0.0 release of Babel changes the syntax for specifying a locale_selector. In 2.x, Babel stores information only for the most recent app; this prevents multiple apps from using the same Babel instance (see python-babel/flask-babel#107). To add support for multiple apps, Babel 3.x moves locale selection into state, and the previous function decoration syntax was removed. Fortunately for fava, all this means is we need to change how we attach `get_locale()` to Babel. It's a simple, two-line change.
ethhics
changed the title
|
Thanks for the PR. I've added two branches to support both older and the new version. Closed by d61295c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of weeks ago, the Python-Babel dependency release version 3.0.0 which contains a breaking change for fava.
This PR changes fava's usage to support the new syntax.
Fixes #1549
I am a small-time contributor who just wants to get this fixed; if you want to add to this PR and/or want me to make modifications, that's all fine
In version 2.x, Babel stores information only for the most recent app;
this prevents multiple apps from using the same Babel instance (see python-babel/flask-babel#107).
To add support for multiple apps, Babel 3.x moves locale selection into per-app state,
which requires a change from the previous function decoration syntax for selecting locale.
Annoyingly, the new syntax is not supported in any 2.x release, which means that either we'll have to trust that the 3.x babel branch works (all tests pass, so that's good), or we'll have to modify this PR to support 2.x or 3.x based on the installed version.