fix(build): add pre-commit as a dev dependency to simplify local de…

…v and CI (testcontainers#438) I could not install pre-commit handler because the package was missing in [tool.poetry.group.dev.dependencies]. I also updated the configuration for the pre-commit handler as black and ruff packages were outdated. Also removed deprecation for ruff v0.3.0 config in pyproject.toml. --------- Co-authored-by: Balint Bartha <[email protected]>
bearrito · Mar 4, 2024 · 7eb4e73 · 7eb4e73
1 parent b380c4f
commit 7eb4e73
Show file tree

Hide file tree

Showing 4 changed files with 134 additions and 15 deletions.
diff --git a/.github/workflows/ci-lint.yml b/.github/workflows/ci-lint.yml
@@ -18,8 +18,6 @@ jobs:
         with:
           python-version: "3.9"  # the pre-commit is hooked in as 3.9
       - name: Install Python dependencies
-        run: poetry install
-      - name: Install pre-commit
-        run: pip install pre-commit
-      - name: Run linter
-        run: pre-commit run -a
+        run: poetry install --no-interaction
+      - name: Execute pre-commit handler
+        run: poetry run pre-commit run -a
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -10,13 +10,13 @@ repos:
       - id: end-of-file-fixer
 
   - repo: https://github.com/psf/black-pre-commit-mirror
-    rev: '24.1.1'
+    rev: '24.2.0'
     hooks:
       - id: black
         args: [ '--config', 'pyproject.toml' ]
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: 'v0.1.14'
+    rev: 'v0.3.0'
     hooks:
       - id: ruff
         # Explicitly setting config to prevent Ruff from using `pyproject.toml` in sub packages.

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -108,12 +108,13 @@ redis = ["redis"]
 selenium = ["selenium"]
 
 [tool.poetry.group.dev.dependencies]
+mypy = "1.7.1"
+pre-commit = "^3.6"
+pg8000 = "*"
 pytest = "7.4.3"
 pytest-cov = "4.1.0"
 sphinx = "^7.2.6"
-pg8000 = "*"
 twine = "^4.0.2"
-mypy = "1.7.1"
 anyio = "^4.3.0"
 
 [[tool.poetry.source]]
@@ -140,15 +141,14 @@ exclude_lines = [
     "raise NotImplementedError" # TODO: used in core/generic.py, not sure we need DbContainer
 ]
 
-[tool.ruff.flake8-type-checking]
-strict = true
-
 [tool.ruff]
 target-version = "py39"
 line-length = 120
 fix = true
-fixable = ["I"]
 src = ["core", "modules/*"]
+
+[tool.ruff.lint]
+fixable = ["I"]
 exclude = ["**/tests/**/*.py"]
 select = [
     # flake8-2020
@@ -195,6 +195,8 @@ ignore = [
     "INP001"
 ]
 
+[tool.ruff.lint.flake8-type-checking]
+strict = true
 
 [tool.mypy]
 python_version = "3.9"