Decode url-safe style base64 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@beatgammit Do you have any thoughts on this? I think it would be nice to have. It's backwards-compatible and unobtrusive since it only makes And it's in node's Buffer 'base64' handling too. |
|
I'm travelling today, but I'll try to look at it this weekend. |
|
@beatgammit Ping! |
|
@beatgammit If you're too busy to take a look, are you cool if I just merge and publish a new version? I guess times like these are when it makes sense to use my commit bit, when other maintainers are too busy :) |
|
Okay, I decided to go for it. Merged and released 0.0.8. |
This was referenced Dec 31, 2014
|
Cool, thanks! I've been travelling the last couple weeks and haven't had time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to help improve buffer's compatibility with node I came across this:
nodejs/node-v0.x-archive@b9127eb
It might be nice to have this here, but it could probably also be done in buffer, open to suggestions.