Add force-aligned feature #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| options: [ | ||
| { name: "wrap_attributes", value: "'force-aligned'" } | ||
| ], | ||
| indent_attr: '\\n ', /* Number of spaces should be dynamic */ |
There was a problem hiding this comment.
Add more matrix vars to deal with the dynamic. It looks like you only need one more - for the <link> and '<root> elements that will have one more space in in this case.
|
I am not sure why it fails. Is the problem on my end ? |
|
Remember to run |
|
My bad, thank you. |
|
So this closes #916, right? This looks great. I've added that bug to this milestone. Could you squash all these to one commit and rebase it on the beautify-web/js-beautify master branch? Then I should be able to merge. |
'force aligned' attribute will align automatically all attributes based on the position of the first attribute.
|
squash and rebase: yes, you did that correctly. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I said (#936 (comment)), I have some issues to how correctly test this feature.
Edit: I will fix the issue about startsWith ASAP.