Fixed bug with css pseudo-classes

[akalongman]

Fixed bug when formatter adds whitespace after colon in a:hover or other pseudo-classes

[evocateur]

Could you add some test cases to verify this fix, please? Also, does the issue repro in the JS version?

[akalongman]

How can I add tests?

[evocateur]

Add expected input and output assertions to beautify-tests.js and testjsbeautifier.py.

After an initial npm install ., execute make test to run the tests for both languages. In most cases, you should be able to copy & paste tests between the Python and JS versions.

[pixelastic]

I'm also interested in this fix. I tried to add some tests to this pull request but couldn't get make test to pass, even on a clean pull of the original repo.

Here is the output of make test for commit c30247f on branch master:

Testing javascript implementation...
v0.10.21

> [email protected] test /home/tca/local/etc/js-beautify-einars
> ./js/test/shell-smoke-test.sh && node ./js/test/node-beautify-tests.js

----------------------------------------
Testing common cli behavior...
Script: /home/tca/local/etc/js-beautify-einars/js/test/../bin/css-beautify.js
----------------------------------------
Testing common cli behavior...
Script: /home/tca/local/etc/js-beautify-einars/js/test/../bin/html-beautify.js
----------------------------------------
Testing common cli behavior...
Script: /home/tca/local/etc/js-beautify-einars/js/test/../bin/js-beautify.js
----------------------------------------
Testing js-beautify cli behavior...
beautified ../../../../../tmp/js-beautify-mkdir/js-beautify.js
Files /home/tca/local/etc/js-beautify-einars/js/test/../bin/css-beautify.js and - differ
beautified ../../../../../tmp/js-beautify-mkdir/example1-default.js
Files /tmp/js-beautify-mkdir/example1-default.js and - differ
Files /tmp/js-beautify-mkdir/example1-default.js and - differ
js-beautify output for /tmp/js-beautify-mkdir/example1-default.js was expected to be different based on HOME settings.
npm ERR! weird error 1
npm ERR! not ok code 0
make: *** [testj] Error 1

If I could get this to pass, I could try to add the missing tests for the PR.

[bitwiseman]

That is strange. c30247f passed in travis-ci. Not sure what could be the problem...

[pixelastic]

I'm running ubuntu 13.10 on a 64bit system, using node v0.10.21.

Steps to reproduce are:

git clone [email protected]:einars/js-beautify.git ./js-beautify
cd ./js-beautify
git checkout c30247fa005b9a5227a6b69ae18efc4460787d98
npm install
make test

Let me know if you need any more information, I'll be glad to help.

[noducks]

In the tests referenced above, ::selection selector fails and ends up as : : selection

[bitwiseman]

Thing have moved forward quite a bit since this was written. Closing. Please merge and reopen if you see the need.