UniqueFieldsMixin validation optional for partial update #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_validate_unique_fields now accounts for partial updates and does not attempt checks fields if they're not available
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
- Coverage 98.13% 97.68% -0.45%
==========================================
Files 3 3
Lines 214 216 +2
==========================================
+ Hits 210 211 +1
- Misses 4 5 +1
Continue to review full report at Codecov.
|
|
Hello @robinchow! Thanks for your contribution! Could you please add tests covering your logic to the PR? |
|
Thanks. Merged |
|
Available in 0.6.2 |
|
:) sweet, thanks! and thank you for your work on this library 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_validate_unique_fields now accounts for partial updates and does not attempt checks on fields if they've not been provided.