json Handlebars helper allows unsafe HTML #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bradvogel, thanks for merging #85! Was wondering if you saw this one—I converted it from an issue so you may have missed it. |
robhanlon22
force-pushed
the
unsafe-html
branch
4 times, most recently
from
9b13b00 to
1122103
Compare
robhanlon22
force-pushed
the
unsafe-html
branch
from
1122103 to
8a390a7
Compare
robhanlon22
force-pushed
the
unsafe-html
branch
from
8a390a7 to
5f5ab84
Compare
ttacon
reviewed
Jan 19, 2018
| return content ? content.join('\n') : null; | ||
| const blocks = this._blocks; | ||
| const content = blocks && blocks[name]; | ||
| return content ? content.join("\n") : null; |
There was a problem hiding this comment.
nit: Let's keep these as (single quotes).
| @@ -1,15 +1,25 @@ | |||
| const _ = require('lodash'); | |||
| const Handlerbars = require('handlebars'); | |||
| const _ = require("lodash"); | |||
There was a problem hiding this comment.
nit: Here and below, let's use single quotes.
|
@ttacon comments addressed! |
|
published as 2.4.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this vulnerability when I added a job to Bull that had job data that included some HTML. Since the
jsonHandlebars helper assumes that its input is safe, any HTML that is rendered onto the job details page will be considered valid, including<script>tags.You can repro this by creating a job in Bull (and maybe in Bee?) with data along the lines of
{ "something": "<script>alert('Hello there!')</script>" }and then opening up the
queueJobsByStatepage that includes the job with unsafe HTML. You'll see an alert.bug is in this helper function:
arena/src/server/views/helpers/handlebars.js
Line 5 in be866d3
I've attached a fix in which all string values are escaped when the object is stringified.