On complete in use animate fix #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bluebill1049 will you please consider this PR? |
|
My next suggestion would be to update this hook with all the bells and whistles that are currently in the hooks of the |
|
thanks for the PR! |
|
could you try to npm install again? looks like it's using a private package for some reason. |
added 2 commits
October 1, 2022 20:17
Previous to this fix, in order to get the `onComplete` to be called, you had to pass in `complete`
The situation here is that the `setAnimate` is being called in a setTimeout callback. By the time the callback has been called, the state may have been changed. But, the way this was written previous to this commit is that it would spread in the old values of state. Instead of doing that, we should use the callback method for setState(), which takes the very latest state as it's first argument, and we spread that here instead.
cgood92
force-pushed
the
onComplete-in-use-animate-fix
branch
from
8f96870 to
415ff17
Compare
I did, I'm so sorry about that. Thanks. I have pushed up the yarn.lock changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 fixes in this PR:
onComplete || complete, notonCompleteTimeRef.current || complete.onCompleteTimeRef.currentis ALWAYS truthy after the first timeuseEffectis ran, because we never setonCompleteTimeRef.currentto anything falsey. We do clear the timeout, but that doesn't change the value ofonCompleteTimeRef.current, which is just a number.setState. See: https://reactjs.org/docs/hooks-reference.html#functional-updates.setAnimatein a callback of asetTimeout, so it is retrieving quite stale state. This is causing me problems when implementing this hook.