Move noscript
position and add imgStyle
into fallback <img />
#66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @bluebill1049, first of all thanks for this cool library.
I found some issues regarding the
<noscript>
part and hope could be useful for every use case.The point is that checking the cases where
<noscript>
should be available as fallback, since is rendered after the regular<img />
, both asrelative
positioned elements, the fallback one remains outside the wrapper which hasoverflow: hidden
styles. Swapping the order, in that case, the regularimg
(not needed) remains overflown.The other point is to pass also
imgStyles
to the fallbackimg
to have the same look and feel as the regular one.Let me know in any case,