Added onActivityResult to MainActivity.java and IPythonApp.java #25
Conversation
| { | ||
| Log.d(TAG, "onActivityResult() start"); | ||
| super.onActivityResult(requestCode, resultCode, data); | ||
| pythonApp.onActivityResult(requestCode, resultCode, data); |
There was a problem hiding this comment.
@freakboy3742 Should we do as hasattr check for pythonApp.onActivityResult here? I think it's OK to skip that check if the template can expect a version of Toga with the new onActivityResult code in beeware/toga#1158 . Wanted to double-check with you.
There was a problem hiding this comment.
I get the intention, but I think this will be safe without the hasattr guard. We're only going to get an activity result if the code starts an activity... and that won't be happening until the code is merged into Toga to start activities in the first place.
|
@t-arn This is really cool! I think it's great. From my perspective, it looks good to me. I'll allow @freakboy3742 to more-officially review it. |
| { | ||
| Log.d(TAG, "onActivityResult() start"); | ||
| super.onActivityResult(requestCode, resultCode, data); | ||
| pythonApp.onActivityResult(requestCode, resultCode, data); |
There was a problem hiding this comment.
I get the intention, but I think this will be safe without the hasattr guard. We're only going to get an activity result if the code starts an activity... and that won't be happening until the code is merged into Toga to start activities in the first place.
Added onActivityResult to MainActivity.java and IPythonApp.java
This PR adds the method onActivityResult() in MainActivity.java and IPythonApp.java
This allows us to invoke Android Intents from Python and get the result back.
This template is used by following pull-request: beeware/toga#1158
PR Checklist: