cocoa: add standard app menu items

[layday]

Added "Hide ", "Hide Others" and "Show All" in a separate
section immediately preceding "Quit". Also added Cmd+, as
a shortcut for "Preferences" and sectioned it off.

Closes #1261.

Signed-off-by: layday [email protected]

PR Checklist:

• All new features have been tested
• All new features have been documented
• I have read the CONTRIBUTING.md file
• I will abide by the code of conduct

[layday]

I don't know if this is the correct approach to using rubicon - happy to shift things around.

[freakboy3742]

This is awesome - thanks for the patch!

I'll merge this as-is, as it's a significant improvement. However, if you're looking for a small place to tinker and tweak, I noticed that the "Show All" option is always active. On other apps, it's disabled unless there are hidden apps. I'm not sure what mechanism is driving that - I'm guessing it has something to do with NSWorkSpaceDidHideApplicationNotification - but it seems weird that every app would need to implement logic to determine if there are currently hidden apps.

[samschott]

I suspect that the automatic enabling and disabling is typically driven by the responder implementing validateUserInterfaceItem:, as described in Apple's docs for automatically enabling or disabling menu items.

In this case, the responder should be NSApplication and the selector should be unhideAllApplications: but toga currently wires all menu items up to the selector selectMenuItem:. To get automatic enabling enabling of menu items (useful also for copy / paste commands), we would probably need to set NSMenu.autoenablesItems to True and set the appropriate selectors at least for such "native" commands.

[layday]

Thanks for merging.

I tried hooking it up to unhideAllApplications directly using a selector, thought that might trigger validateMenuItem but no luck.

[samschott]

Strange, I've just tried this out myself and it works both with hideOtherApplications and unhideAllApplications. Remember to set submenu.setAutoenablesItems(True) for that submenu.

Edit: I'm not sure if this actually calls validateMenuItem or validateUserInterfaceItem but the menu items certainly get enabled / disabled automatically as appropriate.

[layday]

That does work, I was doing it on the menu bar 🤦

When I tried it on the app delegate it was validateMenuItem: being called. I see that sub-menus currently have autoenablesItems set to false, I assume that's for Command.enabled to be picked up? If validateMenuItem: sets the enabled flag on NSMenuItem's then we could implement that and bypass the Command proxy? For instance:

class AppDelegate(NSObject):
    @objc_method
    def validateMenuItem_(self, sender) -> bool:
        cmd = self.interface._impl._menu_items[sender]
        return cmd.enabled

[samschott]

I see that sub-menus currently have autoenablesItems set to false, I assume that's for Command.enabled to be picked up?

Yes, exactly.

If validateMenuItem: sets the enabled flag on NSMenuItem's then we could implement that and bypass the Command proxy?

I like that approach!

[layday]

#1267