If Statement with long expression

[belav]

Currently when an if statement has a long expression, it formats like

if (
    !this.model.TranslatableFields.TryGetValue(
        fieldName,
        out var dictionary
    )
)
{
    return;
}

I think it should do this

if (
    !this.model.TranslatableFields.TryGetValue(
        fieldName,
        out var dictionary
    )
) {
    return;
}

if (shortStatement)
{
    return;
}

or

if (
    !this.model.TranslatableFields.TryGetValue(
        fieldName,
        out var dictionary
    ))
{
    return;
}

if (shortStatement)
{
    return;
}

This applies to other syntax nodes, like for loops and while loops.

[shocklateboy92]

Hmmm. I'm definitely not a fan of # 3. # 2 might make sense if we want to make it consistent with things like constructors or long method defintions:

public Constructor(
    Type arg1,
    Type arg2
) {
    // logic
}

[belav]

I made #2 work, which I'm going to call SpaceBrace (vs NewLineBrace).
I made WhileStatements, IfStatements, ForEachStatements and UsingStatements all use SpaceBrace.
There are a number of other node's that have a block syntax that could also use SpaceBrace.

I see two options

1. Format everything that has a block syntax using SpaceBrace. Which means in the example below, the MethodDeclaration would be changing.
2. Format everything that has the potential to be deeply nested using SpaceBrace, everything else using NewLineBrace. In the code below, the MethodDeclaration can only have parameters, it can't really be any deeper, so it would stay NewLineBrace.

I think I'm leaning towards option 1, because then things are consistent. But I'm not opposed to option 2 either.

    public void LongMethodNameForceLineBreak(
        string oneoneoneoneoneoneoneoneone,
        string twotwotwotwotwotwotwotwo,
        string threethreethreethreethreethree)
    {
        if (
            longStatementName
            && longerStatementName
            && evenLongerStatementName
            && superLongStatementName
        ) {
            return;
        }
    }

[belav]

After working on #58 I'm thinking we go all in on SpaceBrace.
In order to print Lambda methods like this, we need a SoftLine before the close paren. If we wanted to use NewLineBrace we'd have to add extra logic to decide when that SoftLine should be added.

const doSomething = (
  jasdjklfasjkldflajskdflkasdlfjkasdf,
  jalsdfkasdlkfalksflksdf,
  kjladslkfasjfkasdfl
) => doSomethingElse();

[jrobertson-insite]

This is closed... but the spacebrace in all cases as seen in the screenshot below is seemingly not the way the vast majority of C# is formatted in my experience.

Edit: This is not specifically addressed in the MS C# coding conventions but samples basically never use space brace.

https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/inside-a-program/coding-conventions