Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort global System usings before other global usings #1004

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

vipentti
Copy link
Contributor

Fixes #1003

@vipentti
Copy link
Contributor Author

I'm not sure why either of the failed checks actually fail.

Check Formatting seems to fail to something. Locally formatting checks out okay except for the expected after running other tests:

Error ./Src/CSharpier.Cli.Tests/bin/Debug/net8.0/TestFiles/CheckUnformatted.cs - Was not formatted.
  The file did not end with a single newline.
Formatted 302 files in 1254ms.

Without that

dotnet csharpier . --check 
Formatted 301 files in 813ms.

Run Tests seems to fail due so some unrelated issue:

 Unhandled exception: System.AggregateException: One or more errors occurred. 
 (The process cannot access the file '/tmp/1fd44a6a-9e27-45bb-ad6c-bcaaf578e68d/project.assets.json' because it is being used by another process.)

@shocklateboy92
Copy link
Collaborator

The tests are actually failing due to dotnet/sdk#35989

@shocklateboy92
Copy link
Collaborator

@belav can you take a look / update to the latest .net RC? That should fix it.

@belav
Copy link
Owner

belav commented Nov 15, 2023

@belav can you take a look / update to the latest .net RC? That should fix it.

I've been getting past it for now by just running the action again, it usually works the second time. I can hopefully get things updated to the new net8 this weekend.

@vipentti thanks for the fix!

@belav belav merged commit eb56707 into belav:main Nov 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global System using directives should be sorted first
3 participants