formatting with 0.9.4 #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,5 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <Import Project="../../CSharpier.Build.props"/> | |||
| <Import Project="../../CSharpier.Build.props" /> | |||
There was a problem hiding this comment.
Is this the right level of indent?
| @@ -62,7 +62,7 @@ public static Doc PrintWithSuffix(SyntaxToken syntaxToken, Doc suffixDoc) | |||
| && syntaxToken.Text.StartsWith("@")) | |||
| || (syntaxToken.Kind() == SyntaxKind.InterpolatedStringTextToken | |||
| && syntaxToken.Parent!.Parent | |||
| is InterpolatedStringExpressionSyntax { StringStartToken: { RawKind: (int)SyntaxKind.InterpolatedVerbatimStringStartToken } } ) | |||
| is InterpolatedStringExpressionSyntax { StringStartToken: { RawKind: (int)SyntaxKind.InterpolatedVerbatimStringStartToken } }) | |||
There was a problem hiding this comment.
Is there a bug tracking breaking these?
There was a problem hiding this comment.
I believe this is the same problem #214
| @@ -156,12 +158,14 @@ public DropdownAttribute(bool ignoreIfNotPresent) | |||
| [Test] | |||
| public void MissingSemiColon() | |||
| { | |||
| var left = @"public enum Enum | |||
| var left = | |||
| @"public enum Enum | |||
There was a problem hiding this comment.
Okay, the more I think about it, the more I realize: there is no good way to format multiline strings! 😛
There was a problem hiding this comment.
The recent PR I might actually make it easier to keep the @"public enum Enum on the same line, although it may depend on implementing ConditionalGroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.