Better print generic methods and constructors

[dishuk13]

If there is only one generic constraint, we try to keep it on the same line. If more one, they're broken up.
As for the constructor initialiser, it's kept on the same line as the ending brace of the arguments.

Closes #94

[shocklateboy92]

The implementation and tests look good.
Feel free to update to the new pattern matching syntax if you think it's cool 😄

[shocklateboy92]

So, this whole function can be replaced by C# 8/9's new pattern matching syntax 🚀

return constraintClauses.ToList() switch
{
    { Count: 0 } => Doc.Null,
    { Count: 1 } => /* stuff */,
    var list when list[0].Parent is MethodDeclarationSyntax => /* stuff */,
    var list => Doc.Indent(
        Doc.HardLine,
        Doc.Join(Doc.HardLine, list.Select(TypeParameterConstraintClause.Print))
    )                                               
};

[belav]

I think the short constructor long base/this call should get handled, but in general this all looks good.

There are a couple other edge cases I ran into that can probably just go into new issues.

There is no indent on the comment but used to be. Probably not super important.

        public UsesRendererTypesInDeclarations()
        /*MMInvocation*/: base(null, null) { }
// this is probably the same issue
        public ServeCommand(CommandLineApplication parent)
        // We pass arbitrary arguments through to the ASP.NET Core configuration
        : base(throwOnUnexpectedArg: false)

This looks a little weird, but also looked weird before your changes and I'm not really sure how we'd want to format it.

// currently
        private T InstantiateComponent<T>() where T : IComponent =>
            (T)_renderer.InstantiateComponent<T>();
// used to be
        private T InstantiateComponent<T>()
            where T : IComponent => (T)_renderer.InstantiateComponent<T>();

A bigger version of the same thing

// currently
        private static IList<T> GetComponents<T>(RenderTreeBuilder builder) where T : IComponent =>
            builder.GetFrames()
                .AsEnumerable()
                .Where(x => x.FrameType == RenderTreeFrameType.Component)
                .Select(x => (T)x.Component)
                .ToList();
// used to be
        private static IList<T> GetComponents<T>(RenderTreeBuilder builder)
            where T : IComponent =>
            builder.GetFrames()
                .AsEnumerable()
                .Where(x => x.FrameType == RenderTreeFrameType.Component)
                .Select(x => (T)x.Component)
                .ToList();

[belav]

This one should probably change. Here's a real world example.

// now formats as
        public DiagnosticLocation(int line, int column) : this(
            $"{DiagnosticProject.DefaultFilePathPrefix}.cs",
            line,
            column
        ) { }
// used to format as this, which I think is preferable.
        public DiagnosticLocation(int line, int column)
            : this($"{DiagnosticProject.DefaultFilePathPrefix}.cs", line, column) { }

[belav]

When they are both long, I think it looks good

        public ServerInteropTest(
            BrowserFixture browserFixture,
            ToggleExecutionModeServerFixture<Program> serverFixture,
            ITestOutputHelper output
        ) : base(
            browserFixture,
            serverFixture.WithServerExecution().WithAdditionalArguments(GetAdditionalArguments()),
            output
        ) { }

Another example with a long base call which wouldn't fit on a single line. It isn't obvious all the parameters are going to a base call.

            public TestRemoteRenderer(IServiceProvider serviceProvider, IClientProxy client) : base(
                serviceProvider,
                NullLoggerFactory.Instance,
                new CircuitOptions(),
                new CircuitClientProxy(client, "connection"),
                NullLogger.Instance,
                null
            ) { }
// I'm thinking it should break before : base to make it more clear
            public TestRemoteRenderer(IServiceProvider serviceProvider, IClientProxy client)
                : base(
                    serviceProvider,
                    NullLoggerFactory.Instance,
                    new CircuitOptions(),
                    new CircuitClientProxy(client, "connection"),
                    NullLogger.Instance,
                    null
                ) { }

[dishuk13]

Done!

[belav]

This looks a little weird, but also looked weird before your changes and I'm not really sure how we'd want to format it.

// currently
        private T InstantiateComponent<T>() where T : IComponent =>
            (T)_renderer.InstantiateComponent<T>();
// used to be
        private T InstantiateComponent<T>()
            where T : IComponent => (T)_renderer.InstantiateComponent<T>();

A bigger version of the same thing

// currently
        private static IList<T> GetComponents<T>(RenderTreeBuilder builder) where T : IComponent =>
            builder.GetFrames()
                .AsEnumerable()
                .Where(x => x.FrameType == RenderTreeFrameType.Component)
                .Select(x => (T)x.Component)
                .ToList();
// used to be
        private static IList<T> GetComponents<T>(RenderTreeBuilder builder)
            where T : IComponent =>
            builder.GetFrames()
                .AsEnumerable()
                .Where(x => x.FrameType == RenderTreeFrameType.Component)
                .Select(x => (T)x.Component)
                .ToList();

After looking at this again, maybe it doesn't need to change. I'm not sure what else we'd do with it, and I think the new way is better than the old. It might just look odd because I'm not used to seeing generic expression bodied methods.

[dishuk13]

After looking at this again, maybe it doesn't need to change

Yeah, I wouldn't be so sure of either one. I've seen both styles in csharpier-repos. I like the one in this PR just because it preserves a line.