Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lru support #1253

Merged
merged 2 commits into from
May 29, 2024
Merged

feat: add lru support #1253

merged 2 commits into from
May 29, 2024

Conversation

belgattitude
Copy link
Owner

No description provided.

Copy link

changeset-bot bot commented May 29, 2024

🦋 Changeset detected

Latest commit: 73ed713

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@httpx/memo-intl Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

nx-cloud bot commented May 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 73ed713. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codspeed-hq bot commented May 29, 2024

CodSpeed Performance Report

Merging #1253 will degrade performances by 11.86%

Comparing add-lru (73ed713) with main (f71004d)

Summary

❌ 1 regressions
✅ 1 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main add-lru Change
With memoization MIntl.NumberFormatter()`` 76.9 ms 87.2 ms -11.86%

@belgattitude belgattitude merged commit fe460a9 into main May 29, 2024
11 of 12 checks passed
@belgattitude belgattitude deleted the add-lru branch May 29, 2024 07:27
@belgattitude belgattitude mentioned this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant