Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treeu patch #1391

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Treeu patch #1391

merged 4 commits into from
Aug 27, 2024

Conversation

belgattitude
Copy link
Owner

No description provided.

Copy link

changeset-bot bot commented Aug 27, 2024

🦋 Changeset detected

Latest commit: a45fa54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@httpx/treeu Minor
@examples/nextjs-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

nx-cloud bot commented Aug 27, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a45fa54. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.41%. Comparing base (d5f606c) to head (a45fa54).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1391      +/-   ##
==========================================
- Coverage   93.42%   93.41%   -0.02%     
==========================================
  Files         131      131              
  Lines        1278     1275       -3     
  Branches      271      271              
==========================================
- Hits         1194     1191       -3     
  Misses         75       75              
  Partials        9        9              
Flag Coverage Δ
httpx-assert-unit 93.41% <100.00%> (-0.02%) ⬇️
httpx-dsn-parser-unit 93.41% <100.00%> (-0.02%) ⬇️
httpx-exception-unit 93.41% <100.00%> (-0.02%) ⬇️
httpx-json-api-unit 93.41% <100.00%> (-0.02%) ⬇️
httpx-memo-intl-unit 93.41% <100.00%> (-0.02%) ⬇️
httpx-plain-object-unit 93.41% <100.00%> (-0.02%) ⬇️
httpx-treeu-unit 93.41% <100.00%> (-0.02%) ⬇️
Files Coverage Δ
packages/treeu/src/mapper/flat-tree-ws-mapper.ts 93.75% <100.00%> (-0.28%) ⬇️

Copy link

codspeed-hq bot commented Aug 27, 2024

CodSpeed Performance Report

Merging #1391 will not alter performance

Comparing treeu-patch (a45fa54) with main (d5f606c)

Summary

✅ 8 untouched benchmarks

🆕 5 new benchmarks
⁉️ 2 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main treeu-patch Change
🆕 FlatTreeWsMapper.toTreeNodesOrThrow N/A 71 ms N/A
⁉️ FlatTreeWsMapper.toTreeNodes 5.2 ms N/A N/A
🆕 DfsTreeSearch.findOne(id_0) N/A 31.6 µs N/A
🆕 DfsTreeSearch.findOne(id_1000) N/A 552.4 µs N/A
🆕 DfsTreeSearch.findOne(id_5000) N/A 2.5 ms N/A
🆕 DfsTreeSearch.findOne(id_NotExists) N/A 4.9 ms N/A
⁉️ TreeSearch findOne 519.5 µs N/A N/A

@belgattitude belgattitude merged commit 131eb9d into main Aug 27, 2024
18 of 20 checks passed
@belgattitude belgattitude deleted the treeu-patch branch August 27, 2024 07:53
@belgattitude belgattitude mentioned this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant