Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#ifdef CONFIG_BIGNUM missing in qjs.c #109

Closed
samkho opened this issue Mar 10, 2022 · 1 comment
Closed

#ifdef CONFIG_BIGNUM missing in qjs.c #109

samkho opened this issue Mar 10, 2022 · 1 comment

Comments

@samkho
Copy link

samkho commented Mar 10, 2022 •
edited
Loading

Lines 457-458 need to be wrapped inside a #ifdef CONFIG_BIGNUM...#endif block, similar to lines 324-326.

quickjs/qjs.c

Line 457 in 2788d71

if (load_jscalc)

quickjs/qjs.c

Line 324 in 2788d71

#ifdef CONFIG_BIGNUM

@samkho samkho changed the title #ifdef BIGNUM missing in qjs.c #ifdef CONFIG_BIGNUM missing in qjs.c Mar 10, 2022
@bellard
Copy link
Owner

bellard commented Dec 9, 2023

fixed

@bellard bellard closed this as completed Dec 9, 2023
TooTallNate pushed a commit to TooTallNate/quickjs that referenced this issue Dec 18, 2023
@bnoordhuis
Fix AsyncGenerator.prototype.return error handling (bellard#109)
1651282 
A poisoned .constructor property is observable and the resulting
exception should be delivered to the catch handler, not silently
dropped, otherwise the generator hangs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samkho @bellard