Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old GCCs break on 64-bit #125

Closed
FGasper opened this issue Sep 7, 2022 · 1 comment
Closed

Old GCCs break on 64-bit #125

FGasper opened this issue Sep 7, 2022 · 1 comment

Comments

@FGasper
Copy link
Contributor

FGasper commented Sep 7, 2022

Fix:

diff --git a/libbf.h b/libbf.h
index 48e9d95..0457c18 100644
--- a/libbf.h
+++ b/libbf.h
@@ -27,7 +27,7 @@
 #include <stddef.h>
 #include <stdint.h>

-#if INTPTR_MAX >= INT64_MAX
+#if defined(__SIZEOF_INT128__) && (INTPTR_MAX >= INT64_MAX)
 #define LIMB_LOG2_BITS 6
 #else
 #define LIMB_LOG2_BITS 5
FGasper added a commit to FGasper/quickjs that referenced this issue Sep 7, 2022
FGasper added a commit to FGasper/quickjs that referenced this issue Dec 2, 2023
@bellard
Copy link
Owner

bellard commented Dec 22, 2023

fixed

@bellard bellard closed this as completed Dec 22, 2023
andrjohns pushed a commit to andrjohns/quickjs that referenced this issue Dec 26, 2023
andrjohns pushed a commit to andrjohns/quickjs that referenced this issue Dec 26, 2023
GerHobbelt pushed a commit to GerHobbelt/quickjs that referenced this issue Jan 26, 2024
* Squashed 'quickjs/' changes from b5e6289..f87cab0

f87cab0 added String.prototype.at, Array.prototype.at and TypedArray.prototype.at
3106401 keep LTO
cdeca4d updated to unicode 15.0.0
94010ed the BigInt support is now always included
03cc5ec fixed js_proxy_isArray stack overflow (github issue bellard#178)
6de52d8 bf_set_ui() fix (github issue bellard#133)
2788d71 updated to Unicode 14.0.0
8516959 updated test262.conf
446099a added Object.hasOwn()
b9f5880 fixed invalid Array.prototype.push/unshift optimization

git-subtree-dir: quickjs
git-subtree-split: f87cab0

* Ignore emsdk-cache in prettier (caused CI failure in my own repo: https://github.com/tbrockman/quickjs-emscripten/actions/runs/7103978144/job/19337912692).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants