Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there a reason for not installing quickjs-atom.h in make install? #229

Closed
xeioex opened this issue Jan 27, 2024 · 2 comments
Closed

Is there a reason for not installing quickjs-atom.h in make install? #229

xeioex opened this issue Jan 27, 2024 · 2 comments

Comments

@xeioex
Copy link
Contributor

xeioex commented Jan 27, 2024 •
edited
Loading

How to get a value for a well-known symbol directly (not quering Symbol object), like Symbol.isConcatSpreadable, if quickjs-atom.h is not included?
@bellard
Copy link
Owner

bellard commented Jan 27, 2024

quickjs-atom.h is considered as a private header, so it should not be used in user code. So it is better to query the Symbol Object. A specialized version of __JS_NewAtom() for symbols could also be exported.

@xeioex
Copy link
Contributor Author

xeioex commented Jan 29, 2024

Got it, closing the issue.

@xeioex xeioex closed this as completed Jan 29, 2024
chenzd123456 pushed a commit to Micro-Application-Runtime/quickjs that referenced this issue Feb 5, 2024
@bnoordhuis
Implement RegExp 'v' flag, part 1 (bellard#229)
f0ef9e1 
This commit implements the flag itself and teaches the regex engine to
reject previously accepted patterns when in unicodeSets mode.

Refs: quickjs-ng/quickjs#228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xeioex @bellard