Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI. #242

Closed
wants to merge 1 commit into from
Closed

Add CI. #242

wants to merge 1 commit into from

Conversation

FGasper
Copy link
Contributor

@FGasper FGasper commented Feb 18, 2024

This switches the exec test to SIGTERM rather than SIGQUIT since the latter didn’t seem to work in QEMU, and the distinction doesn’t really matter for this test.

This also makes the isatty() check smarter by checking whether STDIN is, in fact, a terminal.

This switches the exec test to SIGTERM rather than SIGQUIT since the
latter didn’t seem to work in QEMU, and the distinction doesn’t really
matter for this test.

This also makes the isatty() check smarter by checking whether STDIN
is, in fact, a terminal.
@FGasper
Copy link
Contributor Author

FGasper commented Mar 3, 2024

@chqrlie is this something the project will accept? There's been no response since I submitted.

Thanks!

@chqrlie
Copy link
Collaborator

chqrlie commented Mar 3, 2024

Hi Felipe, sorry for the lag in responding and handling merge requests. Fabrice and I have been busy with ther projects, but Saúl and Ben managed to revive QuickJS and we are back in the game.

I looked at your patch and cannot merge it as is because I started CI in parallel, along what they did for quickjs-ng. I will soon merge your patch with attribution and add your CI targets.

Thanks for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants