Add support for CMake #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Well then I guess it will be stuck here forever then. |
|
:( |
FYI, you can get the patch file by adding .patch to a pull req, eg. https://github.com/bellard/quickjs/pull/40.patch and then easily send it to the mailing list |
|
CMake won't be accepted in QuickJS. |
Could you explain why? |
|
Is anything being merged to QuickJS nowadays? |
|
Hello,
I have been away for a while, but I intend to work on merging patches by the end of the month.
Best
Chqrlie.
… On 22 Jun 2023, at 14:31, Felipe Gasper ***@***.***> wrote:
Is anything being merged to QuickJS nowadays?
—
Reply to this email directly, view it on GitHub <#40 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE5F5KRBAVPJKCNU7O4MMDTXMQ3LDANCNFSM4UU4IPJA>.
You are receiving this because you are subscribed to this thread.
|
|
@chqrlie does that mean GitHub PRs are now accepted? The repo’s metadata still says to send them to the mailing list. |
cykoder
pushed a commit
to cykoder/quickjs
that referenced
this pull request
Sep 1, 2023
…c_crash fix: pending promise shouldn't release by gc and should free after runtime shutdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake is a build configurator which can generate build recipes for many different build systems. Not only it's able to automatically create the makefiles, it can also create solutions for IDEs, including the MSVC. The support for building on Windows comes with it out-of-the-box. It also supports cross-compilation for any platform and clang.
CMakeLists.txt can replace the Makefile completely. I haven't removed the existing
makefilein this PR because I haven't transplanted all of the targets (as this wasn't my goal) and the CMake recipe only can build the main library.This also defines the 'install' target which honors the FHS and replicates how the existing
makefileinstalls the library and the headers. quickjs installed this way is automatically findable by other projects that support CMake.