Improve cross platform comparability for quickjs. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd love to see this upstream, but FYI: you have to send your patch to the mailing list here: https://www.freelists.org/list/quickjs-devel. PRs are not accepted. |
|
Ah, I see you already did so. |
|
And I also see you added a CMake config. I'm doubtful that would be accepted. |
lygstate
force-pushed
the
msvc
branch
7 times, most recently
from
9411890 to
1a921e5
Compare
So we use a >> (LIMB_BITS - shift) instead, as a is 64 bit width. Signed-off-by: Yonggang Luo <[email protected]>
[main] Building folder: quickjs [build] Starting build [proc] Executing command: "C:\Program Files\CMake\bin\cmake.EXE" --build c:/work/study/languages/typescript/quickjs/build/Release-win32-x86 --config Release --target all -- -j 34 [build] [1/5 20% :: 0.259] Building C object CMakeFiles\quickjs.dir\quickjs.c.obj [build] FAILED: CMakeFiles/quickjs.dir/quickjs.c.obj [build] C:\PROGRA~2\MICROS~1\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x86\cl.exe /nologo -DCONFIG_BIGNUM=\"1\" -DCONFIG_VERSION=\"2020-11-08\" -I. -I..\..\ /DWIN32 /D_WINDOWS /W3 /MD /O2 /Ob2 /DNDEBUG -wd4244 -wd4996 -wd4018 -wd4146 -wd4013 -std:c11 /showIncludes /FoCMakeFiles\quickjs.dir\quickjs.c.obj /FdCMakeFiles\quickjs.dir\quickjs.pdb /FS -c ..\..\quickjs.c [build] ..\..\quickjs.c(41704): error C2099: initializer is not a constant [build] ninja: build stopped: subcommand failed. [build] Build finished with exit code 1
using snprintf instead. Signed-off-by: Yonggang Luo <[email protected]>
…out init. Give it a init value Signed-off-by: Yonggang Luo <[email protected]>
'type cast': cannot convert from 'JSValue' to 'JSValue' JSValueConstCast are not necessary because there is no need of cast when converting type from const void* to void*
lygstate
force-pushed
the
msvc
branch
2 times, most recently
from
f72176c to
731f325
Compare
test262/test/built-ins/Math/asinh/asinh-specialVals.js:11: Test262Error: Math.asinh should produce +0 for +0 Expected SameValue(«-Infinity», «Infinity») to be true test262/test/built-ins/Math/asinh/asinh-specialVals.js:11: strict mode: Test262Error: Math.asinh should produce +0 for +0 Expected SameValue(«-Infinity», «Infinity») to be true test262/test/built-ins/Math/atanh/atanh-specialVals.js:21: Test262Error: Math.atanh should produce -0 for -0 Expected SameValue(«Infinity», «-Infinity») to be true test262/test/built-ins/Math/atanh/atanh-specialVals.js:21: strict mode: Test262Error: Math.atanh should produce -0 for -0 Expected SameValue(«Infinity», «-Infinity») to be true
lygstate
force-pushed
the
msvc
branch
4 times, most recently
from
8a88c72 to
4861160
Compare
Move all platform related functions into quickjs-port.h and quickjs-port.c Add full msvc support. BOOL conflict with Windows.h, do not define it in header file, define it in c file directly Now run-test262 pass all tests match unix platform after add atomic/thread support on win32 by using quickjs-port.h win/stdatomic.h comes from https://github.com/cdschreiber/c11 win/dirent.h comes from https://github.com/tronkko/dirent win/getopt.h comes from mingw Now `make test2-update` passed all tests under msys2/mingw Add worker support in qjs on win32 Fixes tests on win32 as much as possible Signed-off-by: Yonggang Luo <[email protected]>
|
I've inadvertently done the same work in my own pull request... Needless to say that I fully endorse this one, as it seems to be cleaner and better tested! |
|
FYI, you can get the patch file by adding .patch to a pull req, eg. https://github.com/bellard/quickjs/pull/49.patch |
GerHobbelt
pushed a commit
to GerHobbelt/quickjs
that referenced
this pull request
Oct 17, 2023
Implement vm.resolve(promiseLikeHandle)
TooTallNate
pushed a commit
to TooTallNate/quickjs
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split quickjs-port.h out
Add msvc support.
Add cmake building system.
Signed-off-by: Yonggang Luo [email protected]
Signed-off-by: Robikz [email protected]