Fix stack overflow detection #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous detection relied on JS_Eval being called from the same or deeper stack frame than JS_NewRuntime.
I don't think this is exhaustive. This also adds an assert to detect when js_check_stack_overflow is called outside a guard. I'm trying to be conservative and wrap the entrypoints explicitly, but maybe it would make sense to wrap JS_CallInternal instead?
This makes the tests pass again. js_check_stack_overflow seems like it gets called from lots of entrypoints, so this approach allows for wrapping the most important ones without worrying about being exhaustive.
|
This solution has no chance to work. |
|
In retrospect I think I can see that stuff like longjmp would break this. Thanks, and looking forward to the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sketches a fix for #55 if I am understanding things correctly. It has not undergone any sort of rigorous testing.