Flag add __all__/__none__ and eliminate _decompose() #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in its place, use __all__/__none__ class atributes and enabled-bit walking
Changed:
* repr of multiple bits no longer includes compound items
(given {RO = 0, WO = 1, RW = 2, AC = 3}, ~RO is RW|WO)
Broken:
* "Bizarre" flag enums which don't decompose into single-bit values
(e.g. {B=3, C=4})
* IntFlag invert, due to its one-to-many mapping to negative values
belm0
pushed a commit
that referenced
this pull request
Oct 5, 2021
```
Direct leak of 8 byte(s) in 1 object(s) allocated from:
GH-0 0x7f008bf19667 in __interceptor_malloc (/lib64/libasan.so.6+0xb0667)
GH-1 0x7f007a0bee4a in subprocess_fork_exec /home/heimes/dev/python/cpython/Modules/_posixsubprocess.c:774
pythonGH-2 0xe0305b in cfunction_call Objects/methodobject.c:546
```
Signed-off-by: Christian Heimes <[email protected]>
(cherry picked from commit 0d3350d)
Co-authored-by: Christian Heimes <[email protected]>
belm0
pushed a commit
that referenced
this pull request
Oct 5, 2021
* bpo-40791: Make compare_digest more constant-time. The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization. (This is change GH-1 from https://bugs.python.org/issue40791 .) (cherry picked from commit 3172936) Co-authored-by: Devin Jeanpierre <[email protected]>
belm0
pushed a commit
that referenced
this pull request
Feb 12, 2022
) Fix test_gdb.test_pycfunction() for Python built with clang -Og. Tolerate inlined functions in the gdb traceback. When _testcapimodule.c is built by clang -Og, _null_to_none() is inlined in meth_varargs() and so gdb returns _null_to_none() as the frame #1. If it's not inlined, meth_varargs() is the frame #1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept:
__all__class property, which is the composed flag value of all single bits__none__class property, which is the flag value of no enabled bits_decompose()method by using the above attributes and efficient walking of enabled bitschanged behavior:
(e.g. given
{RO = 0, WO = 1, RW = 2, AC = 3},~ROisRW|WO)broken behavior:
(e.g.
{B=3, C=4})IntFlaginvert, due to its one-to-many mapping to negative values