-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 3.0 Migration #37
Conversation
ping on this |
build appears to be failing with HEAD https://gist.github.com/ilovezfs/501cb85c702a9e001e122293890ba65c |
It has dependency on this beltex/SystemKit#25. After it's merged, libs directory submodules need to be updated to point to swift 3 versions and then it should work! |
Anyone wants to clone&run - I've updated this branch to use Swift 3 forks of SCMKit, SystemKit and latest version of CommandLineKit: https://github.com/ealeksandrov/dshb.
|
@ealeksandrov yes that compiles on 10.11 with Xcode 8.2.1 and on 10.12 with Xcode 8.3.3. @beltex what needs to be done to get @ealeksandrov's changes merged? |
@beltex Gentle ping on this. We're bottling for macOS 10.13 High Sierra in Homebrew now and still don't have a Sierra bottle. Also, we've lost the ability to rebuild dshb at all since Homebrew has dropped Yosemite support, and our El Capitan CI uses Xcode 8.2.1. |
@alexpovh have you looked at refreshing this for Xcode 9 and for jatoben/CommandLine#78 ? |
Thanks so much for this @alexpovh! And so sorry about the super late response on this folks! |
dshb didn't install for me via brew on 10.12, looks like it can't build swift 2 anymore
SMCKit: beltex/SMCKit#27
SystemKit: beltex/SystemKit#25
CommandLine: jatoben/CommandLine#83