Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 3.0 Migration #37

Merged
merged 2 commits into from
Oct 5, 2017
Merged

Swift 3.0 Migration #37

merged 2 commits into from
Oct 5, 2017

Conversation

alexpovh
Copy link
Contributor

@alexpovh alexpovh commented Oct 29, 2016

dshb didn't install for me via brew on 10.12, looks like it can't build swift 2 anymore

SMCKit: beltex/SMCKit#27
SystemKit: beltex/SystemKit#25
CommandLine: jatoben/CommandLine#83

@alexpovh alexpovh mentioned this pull request Oct 29, 2016
@ilovezfs
Copy link

ilovezfs commented Jan 8, 2017

ping on this

@ilovezfs
Copy link

ilovezfs commented Jan 8, 2017

build appears to be failing with HEAD https://gist.github.com/ilovezfs/501cb85c702a9e001e122293890ba65c

@alexpovh
Copy link
Contributor Author

alexpovh commented Jan 8, 2017

It has dependency on this beltex/SystemKit#25. After it's merged, libs directory submodules need to be updated to point to swift 3 versions and then it should work!

@ealeksandrov
Copy link

ealeksandrov commented Jun 28, 2017

Anyone wants to clone&run - I've updated this branch to use Swift 3 forks of SCMKit, SystemKit and latest version of CommandLineKit: https://github.com/ealeksandrov/dshb.

git clone --recursive https://github.com/ealeksandrov/dshb
cd dshb
make install

Thanks @alexpovh and @perfaram for your PRs.

@beltex beltex changed the title swift 3.0 migration Swift 3.0 Migration Aug 7, 2017
@ilovezfs
Copy link

ilovezfs commented Sep 1, 2017

@ealeksandrov yes that compiles on 10.11 with Xcode 8.2.1 and on 10.12 with Xcode 8.3.3.

@beltex what needs to be done to get @ealeksandrov's changes merged?

@ilovezfs
Copy link

@beltex Gentle ping on this. We're bottling for macOS 10.13 High Sierra in Homebrew now and still don't have a Sierra bottle. Also, we've lost the ability to rebuild dshb at all since Homebrew has dropped Yosemite support, and our El Capitan CI uses Xcode 8.2.1.

@ilovezfs
Copy link

ilovezfs commented Oct 2, 2017

@alexpovh have you looked at refreshing this for Xcode 9 and for jatoben/CommandLine#78 ?

@beltex
Copy link
Owner

beltex commented Oct 5, 2017

Thanks so much for this @alexpovh! And so sorry about the super late response on this folks!

@beltex beltex merged commit dd759de into beltex:master Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants