Fix parsing modifiers with context of block/elem #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vittly
reviewed
Mar 12, 2018
packages/import-notation/index.js
Outdated
| @@ -58,6 +58,7 @@ function parse(importString, ctx) { | |||
| if(!main.block) { | |||
| main.block = ctx.block; | |||
| main.elem || ctx.elem && (main.elem = ctx.elem); | |||
| acc.add(main); | |||
There was a problem hiding this comment.
need to fix jsdoc "[ctx] - entity to restore block part" > "[ctx] - entity to restore block/elem parts"
There was a problem hiding this comment.
We call it scope in the rest modules. Probably better to rename it here too.
block/elem is the base entity name (not part). But can be used in "part of import string" meaning.
Vittly
reviewed
Mar 12, 2018
| @@ -63,14 +63,11 @@ Context allows to extract portion of entities. | |||
| ```js | |||
| var enties = parse('m:theme=normal', { block: 'button' }); | |||
|
|
|||
| // → [ { block: 'button', mod: { name: 'theme' } }, | |||
| // → [ { block: 'button' }, | |||
There was a problem hiding this comment.
can we enclose ctx in [] in table above like [ctx] ? To mark it optional
|
🆗 |
Previous decision was wrong we actually need to extract main entity Check this issue: bem/webpack-bem-loader#64 Natural dependencies were broken
Yeti-or
force-pushed
the
yeti-or.natural-deps
branch
from
f2eaa92 to
ade638f
Compare
Yeti-or
force-pushed
the
yeti-or.natural-deps
branch
from
ade638f to
fc3d418
Compare
qfox
approved these changes
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous decision was wrong we actually need to extract main entity
Check this issue: bem/webpack-bem-loader#64
Natural dependencies were broken