Fix for query string parameter values being split when they contain a comma (,) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… comma (,) Using System.Web.HttpUtility alternative that does not join the values of query string parameters with matching names
|
Thanks @ezescan-rhys, will take a look as soon as possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is needed to resolve an issue with query string parameters that have one or more commas (,) in their value being split due to the assumption that the .Net framework HttpUtility.ParseQueryString method has joined multiple values with the same parameter name.
For example, the query string "?where=TaxNumber.Replace(" ","") == "1234"&page=1" is split into the following parameters:
"where"="TaxNumber.Replace(" ""
"where"=""") == "1234"
"page"="1"
But it should really be as follows:
"where"="TaxNumber.Replace(" ","") == "1234""
"page"="1"