Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for Jekyll 3 #72

Merged
merged 4 commits into from
Nov 11, 2015
Merged

Conversation

gjtorikian
Copy link
Contributor

Closes #63

I uhhhh opened this in September but didn't submit this. Why?

@gjtorikian
Copy link
Contributor Author

@benbalter Just a head's up that the branch now has some trickery for 1.9.3, since Jekyll 3.x only supports Ruby 2 and higher.

Ruby 1.9.3 was end-of-lifed earlier this year. I assume if you wanted to 💀 Ruby 1.9.3 you'd need a new major version of this gem.

At any rate a bump + release for Jekyll 3 would be much obliged. 🙏

@benbalter
Copy link
Owner

Thanks @gjtorikian. I may drop Jekyll < 3 support to minimize the maintenance burden. #71 is going to require a major bump anyway.

benbalter added a commit that referenced this pull request Nov 11, 2015
Provide support for Jekyll 3
@benbalter benbalter merged commit 0fcbd72 into benbalter:master Nov 11, 2015
@gjtorikian gjtorikian deleted the patch-3 branch November 11, 2015 17:44
@benbalter
Copy link
Owner

I may drop Jekyll < 3 support to minimize the maintenance burden.

And by Jekyll < 3, of course, I mean Ruby 1.9.3.

@benbalter benbalter mentioned this pull request Nov 11, 2015
@benbalter
Copy link
Owner

At any rate a bump + release for Jekyll 3 would be much obliged.

https://github.com/benbalter/jekyll-auth/releases/tag/v2.0.0

@gjtorikian
Copy link
Contributor Author

🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants