Uses the jekyll _config.yml file to determine the webroot path #90
Conversation
| rescue | ||
| {} | ||
| end | ||
| end |
There was a problem hiding this comment.
This can be simplified to:
def self.jekyll_config
@config ||= YAML.safe_load_file(config_file)
rescue
{}
endThere was a problem hiding this comment.
Actually, on second thought, I'm not sure that we should rescue. If the Config has an error, we should fail loudly.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@arthur24b6 thanks for this. Any interest in still seeing this merged? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
I'm interested to see this merged. What information is still needed? |
It looks like there are some merge conflicts on master. If you submit a new PR that resolves those commits, and tests pass, glad to get this merged. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Currently jekyll-auth assumes that the webroot is always _site. If the destination is specified in _config.yml it should be respected.
Note: this is revised from my original PR due to some failures of my coffee this morning.