Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for collection type from the strip_title_exerpt? function #82

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

staticintlucas
Copy link

Remove the check for collection type when determining whether to strip the title from the excerpt. Fixes #81

I'm not super familiar with Jekyll so not sure if this will have any unintended side effects. It seemed to work fine in my testing though.

@welcome
Copy link

welcome bot commented Mar 3, 2022

Welcome! Congrats on your first pull request to Jekyll Titles From Headings. If you haven't already, please be sure to check out the contributing guidelines.

@benbalter
Copy link
Owner

It looks like this was implemented in #28. @qwtel do you recall why posts are special cased and what change in behavior, if any, removing it might have?

@staticintlucas
Copy link
Author

@qwtel @benbalter Any movement on this?

From what I can tell the only difference between posts and any other collection is that by default posts has output: true to generate individual pages. But this is already taken into account by iterating over site.pages which will not include any collections with output: false.

FWIW my original issue would also have been fixed by PR #64, so if you prefer you could merge that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title not being removed from excerpt for any collection other than posts
2 participants