feat: support pr summary for benchmark output #138

EstebanBorai · 2022-11-10T23:58:22Z

Provide support for PR Summary for benchmark output.

Refer: #136

Provide support for PR Summary for benchmark output. Refer: benchmark-action#136

embano1 · 2022-11-20T09:24:13Z

Please don't forgot to also update action.yaml and the README.

EstebanBorai · 2022-11-20T13:18:18Z

Please don't forgot to also update action.yaml and the README.

Of course!

EstebanBorai · 2022-11-21T23:07:36Z

Hi @embano1, thanks for remind me documentation! I addressed documentation here: 45bc41e.

EstebanBorai · 2022-11-21T23:08:04Z

Along with documentation I also added the option to the cargo example we have in our workflows here https://github.com/benchmark-action/github-action-benchmark/pull/138/files#diff-73e17259d77e5fbef83b2bdbbe4dc40a912f807472287f7f45b77e0cbf78792dR45 to check it out

j3hempsey · 2022-12-13T00:37:53Z

src/write.ts

+        ];
+    });
+
+    core.summary.addHeading(`Benchmarks: ${name}`).addTable([headers, ...rows]);


Note this is missing the call to write() to actually send the summary upstream to GitHub

core.summary.addHeading(`Benchmarks: ${name}`).addTable([headers, ...rows]).write();

j3hempsey

LGTM

EstebanBorai · 2023-01-30T05:07:03Z

Hi @embano1 and @ktrz, any news on merging this? It would be cool to use actual repo version over forks if possible. Please let me know if theres something I should update to have this merged soon! 🙌🏻

README.md

edulix · 2023-02-11T06:54:16Z

Just wanted to say - I'd also love this to be merged. Thanks for the good work guys.

EstebanBorai · 2023-02-12T00:53:25Z

Just wanted to say - I'd also love this to be merged. Thanks for the good work guys.

Yeah! Any suggestions or improvements that could get this merged sooner!

embano1 · 2023-02-12T07:08:15Z

See my only comment on the PR, but I'm not a maintainer of this project so can't merge.

Co-authored-by: Michael Gasch <[email protected]>

EstebanBorai · 2023-02-12T15:11:01Z

See my only comment on the PR, but I'm not a maintainer of this project so can't merge.

Just committed! Thanks!

embano1

LGTM

morenol · 2023-02-13T22:32:34Z

@ktrz hey, sorry for pinging you on this PR.

Maybe you could review this and merge if everything looks good to you?

edulix · 2023-02-14T04:55:41Z

Random comment, trying to be helpful: seems like this project would benefit from having you guys, that are already reviewers, [to be able to / feel able to] have the power to merge code into the main branch and do releases, given that @ktrz seems a bit busy these days.

brainstorm · 2023-02-14T04:57:47Z

Random comment, trying to be helpful: seems like this project would benefit from having you guys, that are already reviewers, [to be able to / feel able to] have the power to merge code into the main branch and do releases, given that @ktrz seems a bit busy these days.

And not only this pullrequest, but the others waiting in line plus attention to some of the issues too... I was considering doing a soft fork of this project if this owner/maintainer situation is not addressed soon :-S

ktrz · 2023-02-17T06:18:39Z

Hey @EstebanBorai

Thanks for your contribution. I'd love to merge this PR. I just need the CI errors to be addressed before I can do that.

EstebanBorai · 2023-03-02T13:08:49Z

Hey @EstebanBorai

Thanks for your contribution. I'd love to merge this PR. I just need the CI errors to be addressed before I can do that.

Hi @ktrz sorry for the delay!

I just pushed fixes for tests and lint!

ktrz · 2023-03-05T22:56:19Z

Released in v1.16.0

gaby · 2023-03-06T13:01:57Z

@EstebanBorai @embano1 @ktrz The action.yml was not updated, is that why this feature doesnt work yet?

We are getting an Unexpected Input(s) "summary-always" error.

ktrz · 2023-03-06T14:28:04Z

@EstebanBorai @embano1 @ktrz The action.yml was not updated, is that why this feature doesnt work yet?

We are getting an Unexpected Input(s) "summary-always" error.

Yes, @gaby. That seems to be an issue. Sorry for the oversight. Just released a new version with action.yml update

gaby · 2023-03-06T14:28:55Z

@EstebanBorai @embano1 @ktrz The action.yml was not updated, is that why this feature doesnt work yet?
We are getting an Unexpected Input(s) "summary-always" error.

Yes, @gaby. That seems to be an issue. Sorry for the oversight. Just released a new version with action.yml update

Thank you! 😁

EstebanBorai · 2023-03-06T21:11:05Z

Awesome! Im using it here: https://github.com/infinyon/fluvio/actions/runs/4347865829/attempts/1#summary-11804007347
But looks like we still have to add some titles over [object Object].

feat: support pr summary for benchmark output

ed80d31

Provide support for PR Summary for benchmark output. Refer: benchmark-action#136

EstebanBorai mentioned this pull request Nov 11, 2022

Add support for Github Actions Job Summaries #136

Closed

ruivieira mentioned this pull request Nov 16, 2022

FAI-841: Python benchmarks failing since namespace migration trustyai-explainability/trustyai-explainability-python#82

Merged

chore: document and use for cargo example on gh

45bc41e

EstebanBorai marked this pull request as ready for review November 21, 2022 23:06

j3hempsey reviewed Dec 13, 2022

View reviewed changes

fix: add missing call to write

0bfe57a

EstebanBorai requested a review from j3hempsey December 26, 2022 16:11

TheBrenny mentioned this pull request Dec 28, 2022

Benchmark action is broken for PRs from users without "collaborator" privileges napi-rs/napi-rs#279

Closed

brainstorm mentioned this pull request Jan 3, 2023

Generate Markdown summary report for GitHub Actions CI bheisler/cargo-criterion#48

Open

j3hempsey previously approved these changes Jan 3, 2023

View reviewed changes

Merge branch 'master' into feat/pr-summary

576ae13

embano1 reviewed Jan 30, 2023

View reviewed changes

README.md Outdated Show resolved Hide resolved

Update README.md

032aa5c

Co-authored-by: Michael Gasch <[email protected]>

EstebanBorai dismissed j3hempsey’s stale review via 032aa5c February 12, 2023 15:10

Merge branch 'benchmark-action:master' into feat/pr-summary

b856d50

EstebanBorai requested review from embano1 and j3hempsey and removed request for embano1 and j3hempsey February 12, 2023 16:36

embano1 previously approved these changes Feb 13, 2023

View reviewed changes

j3hempsey previously approved these changes Feb 13, 2023

View reviewed changes

morenol previously approved these changes Feb 13, 2023

View reviewed changes

ktrz previously approved these changes Feb 17, 2023

View reviewed changes

jeremylvln mentioned this pull request Feb 21, 2023

Output a Markdown result directly for custom integrations #154

Open

fix: unit tests missing new prop

f2e739f

EstebanBorai dismissed stale reviews from ktrz, morenol, j3hempsey, and embano1 via f2e739f March 2, 2023 13:06

EstebanBorai requested a review from ktrz March 3, 2023 14:43

EstebanBorai added 2 commits March 3, 2023 22:38

fix: use npm run format

ebe7c3a

fix: use await for write

404db45

ktrz approved these changes Mar 5, 2023

View reviewed changes

ktrz merged commit 78c0eb2 into benchmark-action:master Mar 5, 2023

EstebanBorai deleted the feat/pr-summary branch March 6, 2023 15:26

franvila mentioned this pull request Apr 13, 2023

Performance Test results recorded against the wrong commit kroxylicious/kroxylicious#181

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support pr summary for benchmark output #138

feat: support pr summary for benchmark output #138

EstebanBorai commented Nov 10, 2022

embano1 commented Nov 20, 2022

EstebanBorai commented Nov 20, 2022

EstebanBorai commented Nov 21, 2022

EstebanBorai commented Nov 21, 2022

j3hempsey Dec 13, 2022

EstebanBorai Dec 13, 2022

j3hempsey left a comment

EstebanBorai commented Jan 30, 2023

edulix commented Feb 11, 2023

EstebanBorai commented Feb 12, 2023

embano1 commented Feb 12, 2023

EstebanBorai commented Feb 12, 2023

embano1 left a comment

morenol commented Feb 13, 2023

edulix commented Feb 14, 2023

brainstorm commented Feb 14, 2023

ktrz commented Feb 17, 2023

EstebanBorai commented Mar 2, 2023

ktrz commented Mar 5, 2023

gaby commented Mar 6, 2023

ktrz commented Mar 6, 2023

gaby commented Mar 6, 2023

EstebanBorai commented Mar 6, 2023

feat: support pr summary for benchmark output #138

feat: support pr summary for benchmark output #138

Conversation

EstebanBorai commented Nov 10, 2022

embano1 commented Nov 20, 2022

EstebanBorai commented Nov 20, 2022

EstebanBorai commented Nov 21, 2022

EstebanBorai commented Nov 21, 2022

j3hempsey Dec 13, 2022

Choose a reason for hiding this comment

EstebanBorai Dec 13, 2022

Choose a reason for hiding this comment

j3hempsey left a comment

Choose a reason for hiding this comment

EstebanBorai commented Jan 30, 2023

edulix commented Feb 11, 2023

EstebanBorai commented Feb 12, 2023

embano1 commented Feb 12, 2023

EstebanBorai commented Feb 12, 2023

embano1 left a comment

Choose a reason for hiding this comment

morenol commented Feb 13, 2023

edulix commented Feb 14, 2023

brainstorm commented Feb 14, 2023

ktrz commented Feb 17, 2023

EstebanBorai commented Mar 2, 2023

ktrz commented Mar 5, 2023

gaby commented Mar 6, 2023

ktrz commented Mar 6, 2023

gaby commented Mar 6, 2023

EstebanBorai commented Mar 6, 2023