Read commit id from local #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pksunkara
force-pushed
the
develop
branch
2 times, most recently
from
3c4f5d8 to
2e55c17
Compare
|
I am not sure why this is failing. |
|
@rhysd Would appreciate if you could help me here. |
rhysd
requested changes
Apr 27, 2020
| @@ -443,6 +443,14 @@ This option is useful if you don't want to put benchmark results in GitHub Pages | |||
| you need to keep the JSON file persistently among job runs. One option is using a workflow cache | |||
| with `actions/cache` action. Please read 'Minimal setup' section above. | |||
|
|
|||
| #### `read-commit-id` (Optional) | |||
There was a problem hiding this comment.
Would you rename this input to read-commit-id-from-git?
| message: string; | ||
| timestamp: string; | ||
| message?: string; | ||
| timestamp?: string; |
There was a problem hiding this comment.
These values are not considered to be optional. Please retrieve them from Git command.
EDIT: Note that these properties are used in index.html generated by this action. (e.g. here)
There was a problem hiding this comment.
Getting committer username might be tough since git only has the email and name. What do you want me to do here?
|
Hi, I also need this feature for something like #24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is particularly useful when I am checking out several different commits.