Don't hardcode interp_head offset #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For python 3.7, we were hardcoding the offset of the head interpreter inside the _PyRuntimeState object. This was only valid for 64bit operating systems, and on 32 bit systems caused warnings to be logged out. Fix by generating bindings for the PyRuntimeState struct and use the bindings to figure out the offset of the head interpreter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For python 3.7, we were hardcoding the offset of the head interpreter
inside the _PyRuntimeState object. This was only valid for 64bit operating
systems, and on 32 bit systems caused warnings to be logged out.
Fix by generating bindings for the PyRuntimeState struct and use the
bindings to figure out the offset of the head interpreter.