This repository has been archived by the owner on Feb 17, 2020. It is now read-only.
[Improve] Completion speed #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user has finished swiping, set the `completionSpeed` of the animation based on the speed of the swipe, the duration returned by `transitionDuration:`, and the remaining height of the view Previously, a constant transition time was used, which felt particularly unusual when a user swiped quickly, expecting a quick dismiss.
|
I meant to branch this from master without the other PR included. If you want I can close this and resubmit |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better animation completion speed that is related to swipe velocity, and remaining view visible.
Particularly noticeable when the user swipes quickly, and is expecting a quick dismiss