Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First production fixes #10

Closed
wants to merge 16 commits into from
Closed

First production fixes #10

wants to merge 16 commits into from

Conversation

vv-monsalve
Copy link
Contributor

Hi @benhoepner,

This PR includes some first production fixes for the standard National Park font.
Please merge this PR before working on solving what was reported in #8 which will solve the Fails and Warns reported in #9.

Best,

@aherstowski aherstowski self-requested a review June 14, 2023 17:30
@vv-monsalve
Copy link
Contributor Author

@aherstowski, if you hit the "Resolve conflicts" button, it will provide instructions on how to proceed to solve them and fully merge the PR.
I think the conflict is probably because you started working on the source file before merging this PR.
Let me know how it goes.

@vv-monsalve
Copy link
Contributor Author

@aherstowski Following the comment above, there is a conflict reported, and that's why the PR can't be fully merged.
Screen Shot 2023-06-14 at 15 29 28

@vv-monsalve vv-monsalve mentioned this pull request Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherstowski aherstowski aherstowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vv-monsalve @aherstowski