Skip to content

Commit

Permalink
Note changing TEAM_REX affects DependabotRotaReporter.
Browse files Browse the repository at this point in the history
This might help avoid change happening without this linkage being noticed.
  • Loading branch information
mikerkelly committed Jan 31, 2025
1 parent 631864b commit 2364b31
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions workspace/dependabot/jobs.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ class DependabotRotaReporter(RotaReporter):
The candidates are currently Team Rex (except Katie).
If the candidate definition or Team changes this will affect
the rota offset and the rota will restart at an arbitrary point.
Consider redesigning class to include an offset if that happens.
"""

def get_rota(self) -> dict:
Expand Down
4 changes: 4 additions & 0 deletions workspace/utils/people.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ def by_github_username(cls, github_username):
return cls._by_github_username.get(github_username, default)


# Note that adding to or re-ordering this list will will affect the
# DependabotRotaReporter ordering algorithm, restarting it at an arbitrary
# point. If you need to change this list, consider redesigning that class to
# include an offset.
TEAM_REX = [
People.JON,
People.KATIE,
Expand Down

0 comments on commit 2364b31

Please sign in to comment.