feat: do not generate package json while serving

bennymeg · Mar 10, 2022 · 209702f · 209702f
1 parent 4acace3
commit 209702f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/packages/nx-electron/src/executors/execute/executor.ts b/packages/nx-electron/src/executors/execute/executor.ts
@@ -142,20 +142,19 @@ async function* startBuild(options: ElectronExecuteBuilderOptions, context: Exec
     buildTarget,
     {
       ...options.buildTargetOptions,
+      generatePackageJson: false,
       watch: options.watch,
     },
     context
   );
 }
 
-function runWaitUntilTargets(
-  options: ElectronExecuteBuilderOptions,
-  context: ExecutorContext
-): Promise<{ success: boolean }[]> {
+function runWaitUntilTargets(options: ElectronExecuteBuilderOptions, context: ExecutorContext): Promise<{ success: boolean }[]> {
   return Promise.all(
     options.waitUntilTargets.map(async (waitUntilTarget) => {
       const target = parseTargetString(waitUntilTarget);
       const output = await runExecutor(target, {}, context);
+
       return new Promise<{ success: boolean }>(async (resolve) => {
         let event = await output.next();
         // Resolve after first event

diff --git a/packages/nx-electron/src/utils/generate-package-json.ts b/packages/nx-electron/src/utils/generate-package-json.ts
@@ -13,11 +13,7 @@ import { INDEX_OUTPUT_FILENAME } from './config';
  * @param options
  * @constructor
  */
-export function generatePackageJson(
-  projectName: string,
-  graph: ProjectGraph,
-  options: BuildElectronBuilderOptions
-) {
+export function generatePackageJson(projectName: string, graph: ProjectGraph, options: BuildElectronBuilderOptions) {
   // default package.json if one does not exist
   let packageJson = {
     name: projectName,