Treat iolist of empty binaries as empty body #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvsr
force-pushed
the
empty-req-body-detection
branch
from
a72eff4 to
37cef62
Compare
pvsr
force-pushed
the
empty-req-body-detection
branch
from
37cef62 to
87f0d7e
Compare
pvsr
commented
Jan 22, 2025
| @@ -348,13 +354,6 @@ handle_body(Headers, ReqType0, Body0, Client) -> | |||
| S = hackney_headers_new:get_value(<<"content-length">>, Headers), | |||
| {S, CT, Body0}; | |||
|
|
|||
| _ when is_list(Body0) -> % iolist case | |||
There was a problem hiding this comment.
This case is now handled before calling handle_body.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally when the request body is empty,
handle_bodyis only called for POST and PUT requests, since other methods shouldn't haveContent-TypeandContent-Lengthheaders for empty bodies. But one case is missed in the empty body detection, an iolist containing empty binaries. The gleam hackney wrapper represents empty bodies as[<<>>], triggering this bug and causing gleam-lang/hackney#5.This PR expands the empty body detection to check if the result of
iolist_to_binaryis empty.