Adding readonly in a few more places

benoitf · Nov 10, 2021 · 05db93f · 05db93f
1 parent 4aeae3f
commit 05db93f
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 13 deletions.
diff --git a/src/vs/workbench/contrib/notebook/browser/view/renderers/webviewMessages.ts b/src/vs/workbench/contrib/notebook/browser/view/renderers/webviewMessages.ts
@@ -162,22 +162,22 @@ export interface IOutputRequestMetadata {
 	/**
 	 * Additional attributes of a cell metadata.
 	 */
-	readonly custom?: { [key: string]: unknown; };
+	readonly custom?: { readonly [key: string]: unknown; };
 }
 
 export interface IOutputRequestDto {
 	/**
 	 * { mime_type: value }
 	 */
-	readonly data: { [key: string]: unknown; };
+	readonly data: { readonly [key: string]: unknown; };
 
 	readonly metadata?: IOutputRequestMetadata;
 	readonly outputId: string;
 }
 
 export type ICreationContent =
-	| { type: RenderOutputType.Html; htmlContent: string; }
-	| { type: RenderOutputType.Extension; outputId: string; valueBytes: Uint8Array; metadata: unknown; mimeType: string; };
+	| { readonly type: RenderOutputType.Html; readonly htmlContent: string; }
+	| { readonly type: RenderOutputType.Extension; readonly outputId: string; readonly valueBytes: Uint8Array; readonly metadata: unknown; readonly mimeType: string; };
 
 export interface ICreationRequestMessage {
 	readonly type: 'html';
@@ -187,7 +187,7 @@ export interface ICreationRequestMessage {
 	cellTop: number;
 	outputOffset: number;
 	readonly left: number;
-	readonly requiredPreloads: ReadonlyArray<IControllerPreload>;
+	readonly requiredPreloads: readonly IControllerPreload[];
 	readonly initiallyHidden?: boolean;
 	readonly rendererId?: string | undefined;
 }
@@ -200,10 +200,15 @@ export interface IContentWidgetTopRequest {
 	readonly forceDisplay: boolean;
 }
 
+export interface IMarkupCellScrollTops {
+	readonly id: string;
+	readonly top: number;
+}
+
 export interface IViewScrollTopRequestMessage {
 	readonly type: 'view-scroll';
-	readonly widgets: IContentWidgetTopRequest[];
-	readonly markupCells: { id: string; top: number; }[];
+	readonly widgets: readonly IContentWidgetTopRequest[];
+	readonly markupCells: readonly IMarkupCellScrollTops[];
 }
 
 export interface IScrollRequestMessage {
@@ -259,14 +264,14 @@ export interface IControllerPreload {
 
 export interface IUpdateControllerPreloadsMessage {
 	readonly type: 'preload';
-	readonly resources: IControllerPreload[];
+	readonly resources: readonly IControllerPreload[];
 }
 
 export interface IUpdateDecorationsMessage {
 	readonly type: 'decorations';
 	readonly cellId: string;
-	readonly addedClassNames: string[];
-	readonly removedClassNames: string[];
+	readonly addedClassNames: readonly string[];
+	readonly removedClassNames: readonly string[];
 }
 
 export interface ICustomKernelMessage extends BaseToWebviewMessage {
@@ -324,13 +329,13 @@ export interface IMarkupCellInitialization {
 
 export interface IInitializeMarkupCells {
 	readonly type: 'initializeMarkup';
-	readonly cells: ReadonlyArray<IMarkupCellInitialization>;
+	readonly cells: readonly IMarkupCellInitialization[];
 }
 
 export interface INotebookStylesMessage {
 	readonly type: 'notebookStyles';
 	readonly styles: {
-		[key: string]: string;
+		readonly [key: string]: string;
 	};
 }
 

diff --git a/src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts b/src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts
@@ -1007,7 +1007,7 @@ async function webviewPreloads(ctx: PreloadContext) {
 			}
 		}
 
-		public updateMarkupScrolls(markupCells: { id: string; top: number; }[]) {
+		public updateMarkupScrolls(markupCells: readonly webviewMessages.IMarkupCellScrollTops[]) {
 			for (const { id, top } of markupCells) {
 				const cell = this._markupCells.get(id);
 				if (cell) {