sourcing changes made in feature-jdftx-inputs

src/pymatgen/io/jdftx/generic_tags.py

@@ -17,8 +17,6 @@
 
 import numpy as np
 
-from pymatgen.io.jdftx._input_utils import flatten_list
-
 __author__ = "Jacob Clary, Ben Rich"
 
 
@@ -833,7 +831,7 @@ def _make_str_for_dict(self, tag: str, value_list: list) -> str:
         Returns:
             str: The value converted to a string representation for dict representation.
         """
-        value = flatten_list(tag, value_list)
+        value = _flatten_list(tag, value_list)
         self._check_for_mixed_nesting(tag, value)
         return " ".join([str(x) for x in value])
 
@@ -1102,3 +1100,31 @@ def read(self, tag: str, value_str: str) -> dict:
                 f"Something is wrong in the JDFTXInfile formatting, some values were not processed: {value}"
             )
         return subdict
+
+
+def _flatten_list(tag: str, list_of_lists: list[Any]) -> list[Any]:
+    """Flatten list of lists into a single list, then stop.
+
+    Flatten list of lists into a single list, then stop.
+
+    Parameters
+    ----------
+    tag : str
+        The tag to flatten the list of lists for.
+    list_of_lists : list[Any]
+        The list of lists to flatten.
+
+    Returns
+    -------
+    list[Any]
+        The flattened list.
+    """
+    if not isinstance(list_of_lists, list):
+        raise TypeError(f"{tag}: You must provide a list to flatten_list()!")
+    flist = []
+    for v in list_of_lists:
+        if isinstance(v, list):
+            flist.extend(_flatten_list(tag, v))
+        else:
+            flist.append(v)
+    return flist

tests/io/jdftx/test_input_utils.py

@@ -2,13 +2,13 @@
 
 import pytest
 
-from pymatgen.io.jdftx._input_utils import flatten_list
+from pymatgen.io.jdftx.generic_tags import _flatten_list
 
 
 def test_flatten_list():
-    assert flatten_list("", [1, 2, 3]) == [1, 2, 3]
-    assert flatten_list("", [1, [2, 3]]) == [1, 2, 3]
-    assert flatten_list("", [1, [2, [3]]]) == [1, 2, 3]
-    assert flatten_list("", [1, [2, [3, [4]]]]) == [1, 2, 3, 4]
+    assert _flatten_list("", [1, 2, 3]) == [1, 2, 3]
+    assert _flatten_list("", [1, [2, 3]]) == [1, 2, 3]
+    assert _flatten_list("", [1, [2, [3]]]) == [1, 2, 3]
+    assert _flatten_list("", [1, [2, [3, [4]]]]) == [1, 2, 3, 4]
     with pytest.raises(TypeError):
-        flatten_list("", 1)
+        _flatten_list("", 1)